Use volatile for build singleton dapr http client#590
Merged
Conversation
blackstorm
changed the title
artursouza
approved these changes
Aug 14, 2021
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
============================================
+ Coverage 77.05% 77.16% +0.11%
- Complexity 941 942 +1
============================================
Files 88 88
Lines 3011 3009 -2
Branches 334 334
============================================
+ Hits 2320 2322 +2
+ Misses 528 525 -3
+ Partials 163 162 -1
Continue to review full report at Codecov.
|
mthmulders
pushed a commit
to mthmulders/java-sdk
that referenced
this pull request
Aug 21, 2021
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
artursouza
added a commit
that referenced
this pull request
Aug 30, 2021
* Upgrade Mockito to latest version * Run GitHub Actions on Java 11 and 16 * Run JUnit tests with `--add-opens java.base/java.util=ALL-UNNAMED` * Move Surefire JVM arguments to Maven property * Update build.yml * Update validate.yml * simplily build singleton dapr http (#590) Co-authored-by: Artur Souza <artursouza.ms@outlook.com> * Add Automerge workflow (#605) * Add Automerge workflow The automerge workflow will check for complete and approved pull requests and will merge them automatically. Sources: - For the python script to execute the merge: https://raw.githubusercontent.com/dapr/dapr/master/.github/scripts/automerge.py (only changed the label from "automerge" to "auto-merge") - https://raw.githubusercontent.com/dapr/dapr/master/.github/workflows/dapr-bot-schedule.yml (only copied the automerge part, not the prune_stale part as that was not part of the issue. Resolves #603 * Update automerge-bot.yml * Update automerge-bot.yml Co-authored-by: Artur Souza <artursouza.ms@outlook.com> * Cleanup Maven POM files (#604) Added fixed versions for maven-deploy-plugin & spring-boot-maven-plugin as this would otherwise break in a future maven version. Also fixed some indenting and removed duplicate declarations. Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> * Add support for @PostMapping("/path") to pub/sub topic subscriptions (#583) * Remove duplicate dependency * Transform into managed dependencies * Remove old JUnit version from dependencies * Add tests for DaprBeanPostProcessor * Also register PostMappings that use value * Modify existing pub/sub test to no use @PostMapping(path="...") * Remove added dependencies on AssertJ, Spring Test and Servlet API * Remove test in favour of the sdk-tests one Co-authored-by: Artur Souza <artursouza.ms@outlook.com> * Run JUnit tests in all modules with java.base/java.util and java.base/java.lang opened to all modules Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: 浩 <inf2inf2@outlook.com> Co-authored-by: Tom Cools <tom.cools@live.be> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com>
fackee
pushed a commit
to fackee/java-sdk
that referenced
this pull request
Mar 28, 2022
* Upgrade Mockito to latest version * Run GitHub Actions on Java 11 and 16 * Run JUnit tests with `--add-opens java.base/java.util=ALL-UNNAMED` * Move Surefire JVM arguments to Maven property * Update build.yml * Update validate.yml * simplily build singleton dapr http (dapr#590) Co-authored-by: Artur Souza <artursouza.ms@outlook.com> * Add Automerge workflow (dapr#605) * Add Automerge workflow The automerge workflow will check for complete and approved pull requests and will merge them automatically. Sources: - For the python script to execute the merge: https://raw.githubusercontent.com/dapr/dapr/master/.github/scripts/automerge.py (only changed the label from "automerge" to "auto-merge") - https://raw.githubusercontent.com/dapr/dapr/master/.github/workflows/dapr-bot-schedule.yml (only copied the automerge part, not the prune_stale part as that was not part of the issue. Resolves dapr#603 * Update automerge-bot.yml * Update automerge-bot.yml Co-authored-by: Artur Souza <artursouza.ms@outlook.com> * Cleanup Maven POM files (dapr#604) Added fixed versions for maven-deploy-plugin & spring-boot-maven-plugin as this would otherwise break in a future maven version. Also fixed some indenting and removed duplicate declarations. Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> * Add support for @PostMapping("/path") to pub/sub topic subscriptions (dapr#583) * Remove duplicate dependency * Transform into managed dependencies * Remove old JUnit version from dependencies * Add tests for DaprBeanPostProcessor * Also register PostMappings that use value * Modify existing pub/sub test to no use @PostMapping(path="...") * Remove added dependencies on AssertJ, Spring Test and Servlet API * Remove test in favour of the sdk-tests one Co-authored-by: Artur Souza <artursouza.ms@outlook.com> * Run JUnit tests in all modules with java.base/java.util and java.base/java.lang opened to all modules Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: 浩 <inf2inf2@outlook.com> Co-authored-by: Tom Cools <tom.cools@live.be> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee
pushed a commit
to fackee/java-sdk
that referenced
this pull request
Mar 28, 2022
Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee
pushed a commit
to fackee/java-sdk
that referenced
this pull request
Mar 28, 2022
* Upgrade Mockito to latest version * Run GitHub Actions on Java 11 and 16 * Run JUnit tests with `--add-opens java.base/java.util=ALL-UNNAMED` * Move Surefire JVM arguments to Maven property * Update build.yml * Update validate.yml * simplily build singleton dapr http (dapr#590) Co-authored-by: Artur Souza <artursouza.ms@outlook.com> * Add Automerge workflow (dapr#605) * Add Automerge workflow The automerge workflow will check for complete and approved pull requests and will merge them automatically. Sources: - For the python script to execute the merge: https://raw.githubusercontent.com/dapr/dapr/master/.github/scripts/automerge.py (only changed the label from "automerge" to "auto-merge") - https://raw.githubusercontent.com/dapr/dapr/master/.github/workflows/dapr-bot-schedule.yml (only copied the automerge part, not the prune_stale part as that was not part of the issue. Resolves dapr#603 * Update automerge-bot.yml * Update automerge-bot.yml Co-authored-by: Artur Souza <artursouza.ms@outlook.com> * Cleanup Maven POM files (dapr#604) Added fixed versions for maven-deploy-plugin & spring-boot-maven-plugin as this would otherwise break in a future maven version. Also fixed some indenting and removed duplicate declarations. Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> * Add support for @PostMapping("/path") to pub/sub topic subscriptions (dapr#583) * Remove duplicate dependency * Transform into managed dependencies * Remove old JUnit version from dependencies * Add tests for DaprBeanPostProcessor * Also register PostMappings that use value * Modify existing pub/sub test to no use @PostMapping(path="...") * Remove added dependencies on AssertJ, Spring Test and Servlet API * Remove test in favour of the sdk-tests one Co-authored-by: Artur Souza <artursouza.ms@outlook.com> * Run JUnit tests in all modules with java.base/java.util and java.base/java.lang opened to all modules Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: 浩 <inf2inf2@outlook.com> Co-authored-by: Tom Cools <tom.cools@live.be> Co-authored-by: Dapr Bot <56698301+dapr-bot@users.noreply.github.com> Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
volatilecode will be clear more.Issue reference
None
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
RELEASE NOTE: N/A